refactor: Rename binary and default directory #193
Conversation
hacheigriega
changed the title
hacheigriega
force-pushed
the
hy/daemon-name-change
branch
2 times, most recently
from
63f605a to
4126844
Compare
There was a problem hiding this comment.
Approving, but one concern I have is if we are renaming the home directory the chain uses to ~/.seda and if a person runs both a chain and an overlay node on the same PC they are now using the same directory. In this case, I would be concerned about logs overwriting each other from either binary and user UX, but I don't know if a person is likely to run both on the same machine. I don't see why not, considering the overlay is very light. Maybe we should consider ~/.seda/chain on the chain side and ~/.seda/overlay on the overlay side.
There was a problem hiding this comment.
Do we need to commit this empty file?
There was a problem hiding this comment.
Agreed. It's common for node operators to do rm -rf ~/.seda which would remove the overlay data dir with it.
There is actually a simpler approach, simply do ~/.sedad like osmosis does (~/.osmosisd).
I don't mind changing the folder as long as we make sure that they is no overwriting. 😅 |
|
We should also go over our other projects/docs and update those. The contracts repo has some references that I know of and there's probably more. |
hacheigriega
force-pushed
the
hy/daemon-name-change
branch
from
4126844 to
5fa0b6f
Compare
Explanation of Changes
seda-chaindtosedad.seda-chainto.sedad